Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): chunk map serialize an error #2030

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Hen1ng
Copy link
Contributor

@Hen1ng Hen1ng commented Jan 27, 2025

What does this PR do?

fix some error

new implement of map chunk can not pass all of the unit test in the org.apache.fury.serializer.collection.MapSerializersTest

image
image
I found an error in line 298 of the AbstractMapSequencer file

Related issues

Does this PR introduce any user-facing change?

none

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

none

@Hen1ng Hen1ng requested a review from chaokunyang as a code owner January 27, 2025 09:51
@pandalee99 pandalee99 changed the title Fix chunk map serialize an error fix(java): chunk map serialize an error Jan 27, 2025
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's strange why ci pass in previous pr

@chaokunyang chaokunyang merged commit a907a9a into apache:main Jan 27, 2025
40 checks passed
chaokunyang pushed a commit that referenced this pull request Feb 7, 2025
<!--
**Thanks for contributing to Fury.**

**If this is your first time opening a PR on fury, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**

Contribution Checklist

- The **Apache Fury (incubating)** community has restrictions on the
naming of pr titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).

- Fury has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->

## What does this PR do?

<!-- Describe the purpose of this PR. -->

fix some error

new implement of map chunk can not pass all of the unit test in the
org.apache.fury.serializer.collection.MapSerializersTest


![image](https://github.com/user-attachments/assets/2af5978d-2ebc-4ad9-9ac2-f90511ed5c59)

![image](https://github.com/user-attachments/assets/edc08cc4-495f-4cbe-9f48-0b8e5bcef10e)
I found an error in line 298 of the AbstractMapSequencer file
## Related issues

<!--
Is there any related issue? Please attach here.
none
- #xxxx0
- #xxxx1
- #xxxx2
-->

## Does this PR introduce any user-facing change?
none
<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

## Benchmark
none
<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->

Co-authored-by: hening <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants